Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that created resources are update when needed #576

Merged
merged 5 commits into from
Dec 7, 2021

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Dec 6, 2021

Description

Changes proposed in this pull request:

  • [bug] Ensure that resources created during capact install are update when needed.

  • [enhancement] Ensure that applied CRD was accepted by server.

  • [enhancement] Use cert-manager client to apply the ClusterIssuer CR.

  • [enhancement] Ensure that ClusterIssuer CR was accepted by server.

  • [extended scope] Handle applying CRD for a given Capact version. Currently, we support only latest main CRD or from local path.

    • latest release from main:
    $ capact install --version @latest --helm-repo @latest -v
    Installing Capact on cluster...
     • Installation details:
        Version: 0.5.0-67e2484
        Helm repository: https://storage.googleapis.com/capactio-latest-charts
        CRD location: https://raw.githubusercontent.com/capactio/capact/67e2484/deploy/kubernetes/crds/core.capact.io_actions.yaml
    • latest stable release:
    $ capact install --version @latest -v
    Installing Capact on cluster...
     • Installation details:
        Version: 0.5.0
        Helm repository: https://storage.googleapis.com/capactio-stable-charts
        CRD location: https://raw.githubusercontent.com/capactio/capact/v0.5.0/deploy/kubernetes/crds/core.capact.io_actions.yaml
    • local version:
    $ capact install --version @local -v
     • Installation details:
        Version: @local
        Helm repository: deploy/kubernetes/charts
        CRD location: deploy/kubernetes/crds/core.capact.io_actions.yaml

Related issue(s)

@mszostok mszostok added bug Something isn't working enhancement New feature or request area/cli Relates to CLI labels Dec 6, 2021
@mszostok mszostok force-pushed the one-more-time-i-did-too-much branch from 50cdc1b to 16db78e Compare December 6, 2021 22:57
@pkosiec pkosiec self-assigned this Dec 7, 2021
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌 Just please also address the comment with "extended scope" as we will badly need that 👍 Thanks!

internal/cli/capact/cert_manager.go Outdated Show resolved Hide resolved
internal/cli/capact/crd.go Show resolved Hide resolved
@mszostok mszostok force-pushed the one-more-time-i-did-too-much branch from e0da9fe to 3e9c51e Compare December 7, 2021 13:53
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 works well

internal/cli/capact/parameters.go Outdated Show resolved Hide resolved
internal/cli/capact/parameters.go Show resolved Hide resolved
internal/cli/capact/helpers.go Outdated Show resolved Hide resolved
@mszostok mszostok merged commit 65c7c3b into capactio:main Dec 7, 2021
@mszostok mszostok deleted the one-more-time-i-did-too-much branch December 7, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Relates to CLI bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants