Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitLab REST API Runner #543

Merged
merged 5 commits into from
Nov 2, 2021
Merged

Add GitLab REST API Runner #543

merged 5 commits into from
Nov 2, 2021

Conversation

mszostok
Copy link
Member

Description

Changes proposed in this pull request:

  • Add GitHub REST API Runner
  • Add more verbose error messages

@mszostok mszostok added enhancement New feature or request area/cli Relates to CLI area/documentation Related to all activities around documentation labels Oct 28, 2021
@mszostok mszostok added this to the 0.6.0 milestone Oct 28, 2021
@mszostok mszostok changed the title Add GitHub REST API Runner Add GitLab REST API Runner Oct 28, 2021
@pkosiec pkosiec self-assigned this Oct 29, 2021
pkosiec
pkosiec approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👌 Please take a look on the suggestions before merging 🙂

Makefile Outdated Show resolved Hide resolved
pkg/sdk/validation/interfaceio/validator.go Outdated Show resolved Hide resolved
pkg/runner/glab-api-runner/adapter.go Outdated Show resolved Hide resolved
pkg/runner/glab-api-runner/types.go Outdated Show resolved Hide resolved
@mszostok mszostok force-pushed the add-glab-runner branch 2 times, most recently from 2128dbf to a98f6ab Compare November 2, 2021 09:31
@mszostok mszostok merged commit 2514617 into capactio:main Nov 2, 2021
@mszostok mszostok deleted the add-glab-runner branch November 2, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@lukaszo lukaszo Awaiting requested review from lukaszo

@platten platten Awaiting requested review from platten

Assignees

@pkosiec pkosiec

Labels
area/cli Relates to CLI area/documentation Related to all activities around documentation enhancement New feature or request
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec