Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ClusterRoleBinding, fix get query for ClusterRoleBinding #424

Merged
merged 4 commits into from
Aug 4, 2021
Merged

Remove the ClusterRoleBinding, fix get query for ClusterRoleBinding #424

merged 4 commits into from
Aug 4, 2021

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Aug 3, 2021 •
edited
Loading

Description

Before reviewing, read this comment: #420 (comment)

Changes proposed in this pull request:

  • Remove the ClusterRoleBinding, fix get query for ClusterRoleBinding
  • Ignore evicted Pods
  • Run integration tests without waiting for entry-tests. Currently, we wait ~8min for entry-tests before running e2e tests. IMO it's useless as the e2e test can be started in parallel, in that way we will reduce time to merge in happy path scenarios.

Related issue(s)

@mszostok mszostok added the area/engine Relates to Engine label Aug 3, 2021
@mszostok mszostok added the bug Something isn't working label Aug 3, 2021
@mszostok mszostok merged commit 58fc83d into capactio:main Aug 4, 2021
@mszostok mszostok deleted the fix-tests branch August 4, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszo lukaszo lukaszo approved these changes

@pkosiec pkosiec Awaiting requested review from pkosiec pkosiec is a code owner

@platten platten Awaiting requested review from platten

@Trojan295 Trojan295 Awaiting requested review from Trojan295

Assignees
No one assigned
Labels
area/engine Relates to Engine bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Periodic cluster integration tests fail on testing that proper policy was injected
2 participants
@mszostok @lukaszo