Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info related to #301 #312

Merged
merged 2 commits into from
Aug 28, 2022

Conversation

HarelM
Copy link
Contributor

@HarelM HarelM commented Aug 27, 2022

I've added the relevant data.
As a side not, I would consider removing all the info with all the versions and place this info in the changelog file or a migration.md file in case the instruction are related to how to upgrade from version to version.
Also the red icons looks like bugs or some kind of error so I would consider avoiding them too.
Another thing that can be improved is to place all the information about installation build and run for every platform in the same place instead of splitting the installation and build & run to separate paragraphs - this way you have all the information about a platform in the same place.
If this is something you would like me to open a PR for let me know. I think the readme should be a lot more cleaner...

@jepiqueau
Copy link
Collaborator

@HarelM I will remove info flagged in the readme and you can open a PR for place all the information about installation build and run for every platform in the same place thanks for your contribution it helps me a lot to have a second opinion especially as i am not concentrate on the software development at that time.

@jepiqueau jepiqueau merged commit f66657a into capacitor-community:master Aug 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants