feat(): update to v4 #244
Merged
feat(): update to v4 #244
+233
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rdlabo thanks for the pull request. I'm not understanding this - if I merge it into master, how does that make the plugin available with |
Closed
|
fyi: i will test this on monday and let you know if it works. Code changes looks good so far |
|
@pbowyer test with Capacitor |
|
Thanks for testing @EinfachHans, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using next tag, This plugin can try to test on Capacitor 4.
https://github.com/capacitor-community/camera-preview/releases/tag/v4.0.0-0
However, this update was done automatically by @rdlabo/capacitor-plugin-to-v4 ,and has not been confirmed to work.
https://github.com/rdlabo-team/capacitor-plugin-to-v4
If you have any problems using it, please comment on this thread.
@maintainer Released with next tag to make the world compatible with Capacitor v4. Please check out this pull request and decide if you want to merge or not. Thanks for all your great work, and we look forward to working with you in the future.