Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable service names with non-alphanum characters #355

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daogrady
Copy link
Contributor

@daogrady daogrady commented Oct 8, 2024

Allows "proper" naming of service containing non-alphanumeric names:

service "Foo/Bar" {}

would become

class __Foo_Bar {}  // not exported directly
export { __Foo_Bar as "Foo/Bar" }

and users would have to import like so:

import { "Foo_Bar" as FooBar } from ...
//                      ^ any alias

Note that this creates a discrepancy between service that don't contain special characters, as they are exported as default export, and ones that have names containing special characters, that are only exported in named style.

  • add tests
  • output warning when such a service name is used, as this requires the use of [email protected] or higher. -> only debug message

@daogrady daogrady requested a review from chgeo October 8, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant