Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add jaeger docker image with HANA trace information #1008

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

BobdenOs
Copy link
Contributor

@BobdenOs BobdenOs commented Feb 3, 2025

This PR adds a jaeger and prometheus docker image to the hce docker setup. This allow the HANA Cloud instance to share its trace information with the jaeger Open Telemetry trace APIs. The value that the prometheus image provides is the ability to use the monitoring view of jaeger. Which aggregates the trace information to highlight possible performance pain points.

image

By leveraging @cap-js/telemetry, SAP Passport and HANA traces. It is possible to get a full stack performance overview while in a local development environment. Which is usually only possible in productive landscapes by using dynatrace. By having the detailed trace information locally it enables experimental analysis which is not possible in productive landscapes. Additionally removing the hyper scaler from the equation reduces the number of un controllable factors from the measurement (e.g. noise neighbors, network latency, etc.).

image

This feature combined with explain (#462) create a powerful foundation for ensuring a good performance base line and analysis of poor performing requests.

Copy link
Member

@patricebender patricebender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Would love to try it out but the hce image doesnt run on ARM macs… could I also attach this to a remote HANA?

@BobdenOs
Copy link
Contributor Author

BobdenOs commented Feb 3, 2025

The otel.sh script requires ssh access to the HANA machine. For HANA Cloud instances the same functionality is available in dynatrace. The majority of the information (the blue bars) are generated by @cap-js/telemetry which work for all @cap-js/db-services. Which can be ran directly with the jaeger docker configuration.

@BobdenOs BobdenOs enabled auto-merge (squash) February 5, 2025 14:58
@BobdenOs BobdenOs merged commit 1df2ebc into main Feb 5, 2025
3 checks passed
@BobdenOs BobdenOs deleted the feat/hana-otel branch February 5, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants