Merge pull request #106 from timjrobinson/nested_fields_fix

Fixed null object error when a nested form is submitted but one of the subsections is missing.
caolan · Mar 16, 2014 · 2b6dd73 · 2b6dd73
2 parents ffc092a + 5169858
commit 2b6dd73
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/forms.js b/lib/forms.js
@@ -29,7 +29,9 @@ exports.create = function (fields) {
             b.toHTML = f.toHTML;
             b.fields = {};
             Object.keys(f.fields).forEach(function (k) {
-                b.fields[k] = f.fields[k].bind(data[k]);
+                if (data[k] != null) {
+                    b.fields[k] = f.fields[k].bind(data[k]);
+                }
             });
             b.data = Object.keys(b.fields).reduce(function (a, k) {
                 a[k] = b.fields[k].data;

diff --git a/test/test-form.js b/test/test-form.js
@@ -224,6 +224,16 @@ test('handle empty object', function (t) {
     t.end();
 });
 
+test('handle missing multi-form section', function (t) {
+    t.plan(1);
+    var f = forms.create({
+        section1: {field1: forms.fields.string()},
+        section2: {field1: forms.fields.string()}
+    });
+    f.bind({section1: {field1: "string"}});
+    t.ok(true, 'Form handled missing section ok.');
+});
+
 test('handle error', function (t) {
     t.plan(5);
     var f = forms.create({field1: forms.fields.string()});