-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async.race() method #1018
async.race() method #1018
Conversation
async.race = function (tasks, callback) { | ||
callback = _once(callback || noop); | ||
if (!_isArray(tasks)) { | ||
return callback(new TypeError('First argument to waterfall must be an array of functions')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, change waterfall to race
👍 |
@megawac Should we merge this now, or wait until the modularization is complete? (That branch is almost ready to be merged, just some package questions remaining). |
Either way is fine, I can rebase/cherry-pick any commits onto the On Tue, Feb 2, 2016 at 5:57 PM, Alex Early [email protected] wrote:
|
That would be really helpful. |
Modularization is now on master, so no weird branch to consider now! |
Thanks for the heads up, I will submit a new pr soon. |
Cool @jorgebay. By the way, it might make sense to implement this via |
Yeah, but heads up, we also want to change the arguments for |
Based on the discussion from #568 .
Contains mocha-based tests and readme update.