-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIDAPP-354]: Introduce the Assignment Type Round Robin so that all new service requests are assigned in round robin fashion to applicable managers #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegories with fall back (#327) * Update helpers Signed-off-by: Kevin Ullyott <[email protected]> * Make category pages result using the slug Signed-off-by: Kevin Ullyott <[email protected]> * Fallback to find category based on id Signed-off-by: Kevin Ullyott <[email protected]> * Modify the url param Signed-off-by: Kevin Ullyott <[email protected]> * Remove unused imports Signed-off-by: Kevin Ullyott <[email protected]> * Adjust tthe article view page to work with and redirect to category slug Signed-off-by: Kevin Ullyott <[email protected]> * Fix details on Article viewing page Signed-off-by: Kevin Ullyott <[email protected]> * Formatting fixes Signed-off-by: Kevin Ullyott <[email protected]> * chore: fix enforcement of copyright on all files * chore: implement CategoryShowMissingHandler for category route handling Signed-off-by: Kevin Ullyott <[email protected]> * chore: fix enforcement of copyright on all files * feat: implement ArticleShowMissingHandler for handling missing articles in category routes Signed-off-by: Kevin Ullyott <[email protected]> * chore: fix enforcement of copyright on all files --------- Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
…330) * Start removing assistant objects Signed-off-by: Kevin Ullyott <[email protected]> * Remove some AI things and consent Signed-off-by: Kevin Ullyott <[email protected]> * Remove assistant stuff Signed-off-by: Kevin Ullyott <[email protected]> * More deletes Signed-off-by: Kevin Ullyott <[email protected]> * Legacy database Signed-off-by: Kevin Ullyott <[email protected]> * Delete all of the AI integration Signed-off-by: Kevin Ullyott <[email protected]> * Migrations to delete old tables Signed-off-by: Kevin Ullyott <[email protected]> * Delete old AI cluster Signed-off-by: Kevin Ullyott <[email protected]> * More fixes and migrations Signed-off-by: Kevin Ullyott <[email protected]> * Delete assistant related permissions Signed-off-by: Kevin Ullyott <[email protected]> * chore: fix enforcement of copyright on all files * Final cleanup and fixes Signed-off-by: Kevin Ullyott <[email protected]> * chore: fix enforcement of copyright on all files * chore: fix code style --------- Signed-off-by: Kevin Ullyott <[email protected]> Co-authored-by: joelicatajr <[email protected]>
…ection name change for KB article details for deployed tenants (#334) * Add a data migration to update media collection name for knowledge base items Signed-off-by: Kevin Ullyott <[email protected]> * chore: fix enforcement of copyright on all files --------- Signed-off-by: Kevin Ullyott <[email protected]>
…ication are done over HTTPS (#335) * [OLYMPUS-196]: Ensure all requests between Olympus and the other application are done over HTTPS * Do not verify signature locally
#328) * Contract Management and Contract Types * Minor fixes * Resolve suggestions * Resolve suggestions & contract type factory changes * Resolve suggestions * moved contract management to new contract management module * Resolved linting issue * Moved morph map to module service provider * chore: fix enforcement of copyright on all files --------- Co-authored-by: ankit-canyon <[email protected]>
…#332) * Introduce the ability to manage licenses in the product is done only click to reveal functionality remaining * chore: fix enforcement of copyright on all files * add product license model in morphMap * chore: fix code style * Ensure column extends correct class, ensure column is not clickable to open the View/Edit action * Make changes for expiration date and license field * Worked on PR Review Changes. All changes done except css blur effect * chore: fix code style * New masked column/entry design * Worked on remaining changes * revert delelted folder by mistake * resolved lint errors and removed unneccesary files * add unit test cases and remove unneccessary file * added placeholder in expiration date * chore: fix enforcement of copyright on all files * Remove gitkeep files Signed-off-by: Kevin Ullyott <[email protected]> * Fix the permission names Signed-off-by: Kevin Ullyott <[email protected]> * Fix Product License status generation Signed-off-by: Kevin Ullyott <[email protected]> * Update the composer lock file Signed-off-by: Kevin Ullyott <[email protected]> * chore: fix code style --------- Signed-off-by: Kevin Ullyott <[email protected]> Co-authored-by: ketan-canyon <[email protected]> Co-authored-by: danharrin <[email protected]> Co-authored-by: Kevin Ullyott <[email protected]> Co-authored-by: Orrison <[email protected]>
Orrison
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danharrin please review as well when you have a moment.
...ations/2024_11_20_145140_add_round_robin_last_assigned_id_in_service_request_types_table.php
Outdated
Show resolved
Hide resolved
...ations/2024_11_20_145140_add_round_robin_last_assigned_id_in_service_request_types_table.php
Outdated
Show resolved
Hide resolved
...ations/2024_11_20_145140_add_round_robin_last_assigned_id_in_service_request_types_table.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/src/Actions/CreateServiceRequestAction.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/src/DataTransferObjects/ServiceRequestDataObject.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/tests/ServiceRequest/CreateServiceRequestTest.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/tests/ServiceRequest/CreateServiceRequestTest.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/tests/ServiceRequest/CreateServiceRequestTest.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/tests/ServiceRequest/CreateServiceRequestTest.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/tests/ServiceRequest/CreateServiceRequestTest.php
Outdated
Show resolved
Hide resolved
Orrison
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of small tweaks
app-modules/service-management/src/Services/ServiceRequestType/IndividualAssigner.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/src/Services/ServiceRequestType/RoundRobinAssigner.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/tests/ServiceRequest/CreateServiceRequestTest.php
Outdated
Show resolved
Hide resolved
app-modules/service-management/tests/ServiceRequest/CreateServiceRequestTest.php
Outdated
Show resolved
Hide resolved
Orrison
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.