Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-291]: Performance improvements #500

Merged
merged 9 commits into from
Feb 8, 2024
Merged

[ADVAPP-291]: Performance improvements #500

merged 9 commits into from
Feb 8, 2024

Conversation

danharrin
Copy link
Contributor

@danharrin danharrin commented Feb 5, 2024

Ticket(s) or GitHub Issue

Technical Description

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream main branch.

@danharrin danharrin requested a review from a team February 5, 2024 17:52
@danharrin danharrin marked this pull request as draft February 5, 2024 17:52
@danharrin
Copy link
Contributor Author

Hey @Orrison there are some commands in the todo section that could be added to the Docker setups, just making you aware these are here.

@danharrin danharrin assigned danharrin and unassigned Orrison Feb 5, 2024
@danharrin danharrin marked this pull request as ready for review February 7, 2024 12:28
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry one small improvement that I found out later on

docker/s6-overlay/scripts/cache-icons Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit b7faa36 into main Feb 8, 2024
7 checks passed
@Orrison Orrison deleted the advapp-291 branch February 8, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants