Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-255]: Introduce embeddable forms for Service Requests #471

Merged
merged 21 commits into from
Jan 25, 2024

Conversation

dgoetzit
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

This PR introduces embeddable Service Request Forms which create Service Requests upon submission.

Types of changes

  • New feature (non-breaking change which adds functionality)

Screenshots (if appropriate)

Any deployment steps required?

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@dgoetzit dgoetzit self-assigned this Jan 25, 2024
@dgoetzit dgoetzit requested review from Orrison and a team January 25, 2024 18:34
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting and tests are currently failing

app-modules/service-management/routes/api.php Outdated Show resolved Hide resolved
widgets/service-request-form/src/App.vue Outdated Show resolved Hide resolved
@dgoetzit dgoetzit requested a review from Orrison January 25, 2024 20:59
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
17.8% Duplication on New Code

See analysis details on SonarCloud

@Orrison Orrison merged commit 8d0eb61 into main Jan 25, 2024
7 checks passed
@Orrison Orrison deleted the feature/ADVAPP-255-embed-service-form branch January 25, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants