Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Domains #403

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Local Domains #403

merged 3 commits into from
Dec 27, 2023

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Dec 26, 2023

Ticket(s) or GitHub Issue

  • N/A

Technical Description

This will now set up our local machines to automatically create a custom domain and apply SSL for https://advising.local. Orbstack is required in order for this to work.

If you would like to still use localhost and/or do not have Orbstack locally set up then keeping the following .env variables will allow for that:

APP_URL=http://localhost
APP_FORCE_HTTPS=false

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

Signed-off-by: Kevin Ullyott <[email protected]>
@Orrison Orrison requested a review from a team December 26, 2023 20:56
@Orrison Orrison self-assigned this Dec 26, 2023
dgoetzit
dgoetzit previously approved these changes Dec 27, 2023
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
@Orrison Orrison requested a review from dgoetzit December 27, 2023 14:18
@Orrison Orrison merged commit 5b48fcf into develop Dec 27, 2023
5 checks passed
@Orrison Orrison deleted the feature/local-domain branch December 27, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants