Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVISING-1103]: Introduce Portal Settings #370

Merged
merged 3 commits into from
Dec 18, 2023
Merged

[ADVISING-1103]: Introduce Portal Settings #370

merged 3 commits into from
Dec 18, 2023

Conversation

danharrin
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

Using the Spatie settings package.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Content or styling update (Changes which don't affect functionality)
  • DevOps
  • Documentation

Screenshots (if appropriate)

Screenshot 2023-12-15 at 18 48 24 Screenshot 2023-12-15 at 18 48 42 Screenshot 2023-12-15 at 18 50 34

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

Orrison
Orrison previously approved these changes Dec 18, 2023
@Orrison Orrison changed the base branch from main to develop December 18, 2023 18:58
@Orrison Orrison dismissed their stale review December 18, 2023 18:58

The base branch was changed.

Orrison
Orrison previously approved these changes Dec 18, 2023
@Orrison Orrison merged commit 13b24f7 into develop Dec 18, 2023
5 checks passed
@Orrison Orrison deleted the advising-1103 branch December 18, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants