Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVISING-979]: Introduce "Surveys" Under Manage Surveys #369

Merged
merged 18 commits into from
Dec 19, 2023

Conversation

dgoetzit
Copy link
Contributor

Ticket(s) or GitHub Issue

https://engage.canyongbs.com/workgroups/group/3/tasks/task/view/979/

Technical Description

This PR adds support for surveys

Types of changes

  • New feature (non-breaking change which adds functionality)

Screenshots (if appropriate)

Any deployment steps required?

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@dgoetzit dgoetzit self-assigned this Dec 15, 2023
@dgoetzit dgoetzit requested a review from a team December 15, 2023 16:31
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but left a note on what should be re-used from the Forms directory/namespace.

We want to reuse as much content/styling as we can from Forms so changes remain consistent between the 3 different Form types in the app. Until we have a specific reason to split.

widgets/survey/src/FormKit/Inputs/OneTimePassword.vue Outdated Show resolved Hide resolved
@dgoetzit dgoetzit requested a review from Orrison December 19, 2023 01:05
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some CI failures.

@Orrison Orrison merged commit ad07c17 into develop Dec 19, 2023
5 checks passed
@Orrison Orrison deleted the feature/ADVISING-979-surveys branch December 19, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants