Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVISING-1003]: Enforce License Rules for Forms #362

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

mxm1070
Copy link
Contributor

@mxm1070 mxm1070 commented Dec 14, 2023

Ticket(s) or GitHub Issue

https://engage.canyongbs.com/workgroups/group/3/tasks/task/view/1003/

Technical Description

Enforce License Rules for Forms.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • New feature (non-breaking change which adds functionality)

Screenshots (if appropriate)

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@mxm1070 mxm1070 requested a review from Orrison December 14, 2023 00:57
@mxm1070 mxm1070 self-assigned this Dec 14, 2023
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

Let's do the same thing in Forms that we did for Applications. See EnsureOnlineAdmissionsFeatureIsActive and apply that to the forms API routes.

That way the widget does not render if the feature is off.

@mxm1070 mxm1070 requested a review from Orrison December 14, 2023 21:12
@Orrison Orrison merged commit 6e005fd into develop Dec 14, 2023
5 checks passed
@Orrison Orrison deleted the feature/advising-1003-enforce-license-rules-forms branch December 14, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants