[ADVISING-1065]: Insert template into Text Message #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoetzit
changed the base branch from
develop
to
feature/ADVISING-1067-my-team-template
Base automatically changed from
feature/ADVISING-1067-my-team-template
to
develop
December 5, 2023 14:29
Orrison
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Looks good! I just had a couple of questions/thoughts. I would also like @danharrin to review as well.
app-modules/engagement/src/Filament/Actions/BulkEngagementAction.php
Outdated
Show resolved
Hide resolved
app-modules/engagement/src/Filament/Resources/EngagementResource/Pages/EditEngagement.php
Outdated
Show resolved
Hide resolved
danharrin
previously approved these changes
Dec 5, 2023
Orrison
requested changes
Dec 6, 2023
# Conflicts: # app-modules/engagement/src/Filament/Resources/SmsTemplateResource/Pages/CreateSmsTemplate.php
Orrison
requested changes
Dec 7, 2023
# Conflicts: # _ide_helper_models.php
Orrison
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
https://engage.canyongbs.com/workgroups/group/3/tasks/task/view/1065/
Technical Description
This PR provides the ability to users to load sms templates into a text based engagement. It also simplifies some of the handling of engagements in relation to the body content, as now sms and email utilize the same data types. This also addresses ADVISING-1075
Types of changes
Screenshots (if appropriate)
Any deployment steps required?
Before contributing and submitting this PR, make sure you have:
developbranch.