Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVISING-997]: Enforce License Rules for Users #326

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Dec 4, 2023

Ticket(s) or GitHub Issue

Technical Description

Prevents going to add additional Users if you have exceeded the license limit. Displays the Limit on the Users list page.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • New feature (non-breaking change which adds functionality)

Screenshots (if appropriate)

Screenshot 2023-12-04 at 6 39 53 PM Screenshot 2023-12-04 at 6 39 38 PM Screenshot 2023-12-04 at 6 38 51 PM

Any deployment steps required?

A deployment step could be a command that needs to be executed or an ENV key that needs to be added, for example.

  • Yes, please specify
  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

Signed-off-by: Kevin Ullyott <[email protected]>
@Orrison Orrison requested a review from a team December 4, 2023 23:42
@Orrison Orrison self-assigned this Dec 4, 2023
Signed-off-by: Kevin Ullyott <[email protected]>
@Orrison Orrison requested a review from danharrin December 6, 2023 15:49
danharrin
danharrin previously approved these changes Dec 6, 2023
Base automatically changed from feature/ADVISING-999-license-rules-for-admissions to develop December 6, 2023 23:56
@Orrison Orrison dismissed danharrin’s stale review December 6, 2023 23:56

The base branch was changed.

@Orrison Orrison requested review from danharrin and a team December 6, 2023 23:56
@Orrison
Copy link
Collaborator Author

Orrison commented Dec 6, 2023

@danharrin or @canyongbs/canyon-GBS-lead-developers I need a re-approval as the upstream merged in and changed the base branch here.

@Orrison Orrison merged commit 49a394e into develop Dec 7, 2023
5 checks passed
@Orrison Orrison deleted the feature/ADVISING-997-license-rules-for-users branch December 7, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants