Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVISING-1067]: Introduce My Team filter for selecting email or text message templates #324

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

dgoetzit
Copy link
Contributor

@dgoetzit dgoetzit commented Dec 4, 2023

Ticket(s) or GitHub Issue

https://engage.canyongbs.com/workgroups/group/3/tasks/task/view/1067/

Technical Description

This PR adds a "My Team" checkbox filter to the email template selection modal for engagements. It also resolves an issue with attaching users because of a newly introduced json column to the users table. See the following for reference: filamentphp/filament#8698, https://www.postgresql.org/docs/current/datatype-json.html

We may want to use jsonb as the column type in other situations as well, to avoid this issue elsewhere in the future.

Types of changes

  • New feature (non-breaking change which adds functionality)

Screenshots (if appropriate)

Any deployment steps required?

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@dgoetzit dgoetzit self-assigned this Dec 4, 2023
@dgoetzit dgoetzit changed the base branch from main to develop December 4, 2023 22:39
@dgoetzit dgoetzit requested review from Orrison and danharrin December 4, 2023 22:40
@Orrison Orrison merged commit 8f27a18 into develop Dec 5, 2023
5 checks passed
@Orrison Orrison deleted the feature/ADVISING-1067-my-team-template branch December 5, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants