[ADVAPP-1199] Feature Flag Cleanup: EngagementFilesCreatedByFeature

app-modules/engagement/src/Filament/Resources/EngagementFileResource/RelationManagers/EngagementFilesRelationManager.php

@@ -39,7 +39,6 @@
 use AdvisingApp\Engagement\Filament\Resources\EngagementFileResource;
 use AdvisingApp\Engagement\Models\EngagementFile;
 use AdvisingApp\Prospect\Models\Prospect;
-use App\Features\EngagementFilesCreatedByFeature;
 use App\Filament\Tables\Columns\IdColumn;
 use Filament\Forms\Form;
 use Filament\Resources\RelationManagers\RelationManager;
@@ -117,12 +116,10 @@ public function table(Table $table): Table
                     }),
                 TextColumn::make('created_at')
                     ->label('Date Created')
-                    ->sortable(query: fn ($query, $direction) => $query->orderBy('engagement_files.created_at', $direction))
-                    ->visible(fn (): bool => EngagementFilesCreatedByFeature::active()),
+                    ->sortable(query: fn ($query, $direction) => $query->orderBy('engagement_files.created_at', $direction)),
                 TextColumn::make('createdBy.name')
                     ->label('Created By')
-                    ->sortable(query: fn ($query, $direction) => $query->orderBy('engagement_files.created_by_id', $direction))
-                    ->visible(fn (): bool => EngagementFilesCreatedByFeature::active()),
+                    ->sortable(query: fn ($query, $direction) => $query->orderBy('engagement_files.created_by_id', $direction)),
             ])
             ->headerActions([
                 CreateAction::make()

app-modules/engagement/src/Observers/EngagementFileObserver.php

@@ -37,15 +37,14 @@
 namespace AdvisingApp\Engagement\Observers;
 
 use AdvisingApp\Engagement\Models\EngagementFile;
-use App\Features\EngagementFilesCreatedByFeature;
 
 class EngagementFileObserver
 {
     public function creating(EngagementFile $engagementFile): void
     {
         $user = auth()->user();
 
-        if (EngagementFilesCreatedByFeature::active() && is_null($engagementFile->created_by_id)) {
+        if (is_null($engagementFile->created_by_id)) {
             $engagementFile->created_by_id = $user?->getKey();
             $engagementFile->created_by_type = $user?->getMorphClass();
         }