Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADVAPP-1143]: After saving edits to an item (e.g., prospect), return the user to the view route for the service request #1250

Merged
merged 6 commits into from
Jan 21, 2025
Merged

[ADVAPP-1143]: After saving edits to an item (e.g., prospect), return the user to the view route for the service request #1250

merged 6 commits into from
Jan 21, 2025

Conversation

jayushi-canyon
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

After saving edits to an item (e.g., prospect), return the user to the view route for the service request

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

No

Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

@jayushi-canyon jayushi-canyon added the Change Type | New Feature New feature or request label Jan 17, 2025
@jayushi-canyon jayushi-canyon marked this pull request as ready for review January 20, 2025 12:35
@jayushi-canyon jayushi-canyon requested a review from a team as a code owner January 20, 2025 12:35
@jayushi-canyon jayushi-canyon requested review from danharrin and a team January 20, 2025 19:01
Orrison
Orrison requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is just a merge conflict to resolve.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Orrison Orrison dismissed danharrin’s stale review January 21, 2025 15:05

Dismissed as approval was met

@Orrison Orrison added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 1a52db3 Jan 21, 2025
7 checks passed
@Orrison Orrison deleted the feature/ADVAPP-1143 branch January 21, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orrison Orrison Orrison approved these changes

@danharrin danharrin Awaiting requested review from danharrin

Assignees
No one assigned
Labels
Change Type | New Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayushi-canyon @Orrison @danharrin @joelicatajr