Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

look for csf3 export if storiesOf import is not detected #39

Merged
merged 2 commits into from
Aug 16, 2023
Merged

look for csf3 export if storiesOf import is not detected #39

merged 2 commits into from
Aug 16, 2023

Conversation

fa93hws
Copy link
Contributor

@fa93hws fa93hws commented Aug 15, 2023

I hate multi repos 😭

bradzacher
bradzacher reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to take a different approach.

If the import is found -> look for storiesOf, then look for export default if it's not found
If the import isn't found -> just look for export default.

@bradzacher
Copy link
Member

Also we should probably just move this internally given taht it's all canva-specific logic.
Waste of our time maintaining this as open source TBH

@fa93hws fa93hws force-pushed the eric/csf3-no-looking-imports branch from d095a96 to cf05881 Compare August 16, 2023 00:08
@fa93hws fa93hws changed the title stop checking whether storybook is imported look for csf3 export if storiesOf import is not detected Aug 16, 2023
@fa93hws fa93hws merged commit a2ceee6 into main Aug 16, 2023
4 checks passed
@fa93hws fa93hws deleted the eric/csf3-no-looking-imports branch August 16, 2023 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fa93hws @bradzacher