Merge latest main
before running Percy
#5300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
main
and a PR, rather than the PR head commit.main
into each PR before running Percy.main
- Percy will not be triggered if merge conflicts are detected, since GH doesn't run workflows on PRs with merge conflicts.repository
parameter from the Percy prepare job as it is no longer needed.Context:
Merging
main
into the checked out commit is default behavior foractions/checkout
, but it is documented poorly (see issue). Our current code is forcing actions/checkout to check out the head of the PR (ignoringmain
) - so all we need to do in order to mergemain
into the checked out code is get rid ofrepository
andref
inputs toactions/checkout
.Fixes #5282, WD-13965
QA
scss/_vanilla.scss
and verify line 4 reads// This was added by the PR Test
._vanilla.scss
is not in the main branch of my fork, and was added by the test PR.scss/_base.scss
and verify line 2 reads// This was added by the main branch
._base.scss
is only in the main branch of my fork, and is not present in my PR's source.Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: