Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit card management updates #14670

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Conversation

andesol
Copy link
Contributor

@andesol andesol commented Jan 22, 2025

Done

  • Update "payment methods" page to allow removing the payment method
  • If removed, cancel auto-renewal on pro subscriptions
  • If removed, show warning notification on Pro dashboard
  • Use singular: "Payment method", as there's only one

QA

  • Open demo or run site locally
  • Go to /account/payment-methods
  • Remove the credit card
  • Check that the card goes away and it shows an empty state type of page
  • Go to /pro/dashboard
  • Check that subscriptions have auto-renewal off
  • Check that there's a notification under "Renewal settings"
  • Check you see a notification when editing a subscription
  • Compare with design

Issue

https://warthogs.atlassian.net/browse/WD-18327

@webteam-app
Copy link

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.32%. Comparing base (c4540a6) to head (cb9ec35).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
static/js/src/advantage/api/contracts.js 0.00% 4 Missing ⚠️
...bscriptionList/RenewalSettings/RenewalSettings.tsx 84.61% 2 Missing ⚠️
...s/src/advantage/react/hooks/useHasPaymentMethod.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14670   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files         120      121    +1     
  Lines        3404     3426   +22     
  Branches     1172     1179    +7     
=======================================
+ Hits         2462     2478   +16     
- Misses        917      923    +6     
  Partials       25       25           
Files with missing lines Coverage Δ
...ubscriptions/SubscriptionEdit/SubscriptionEdit.tsx 83.57% <100.00%> (+0.48%) ⬆️
.../checkout/components/UserInfoForm/UserInfoForm.tsx 68.38% <ø> (ø)
...bscriptionList/RenewalSettings/RenewalSettings.tsx 96.25% <84.61%> (+0.30%) ⬆️
...s/src/advantage/react/hooks/useHasPaymentMethod.ts 75.00% <75.00%> (ø)
static/js/src/advantage/api/contracts.js 22.64% <0.00%> (-0.89%) ⬇️

@andesol andesol force-pushed the credit-card-mgmt branch 3 times, most recently from f3218f8 to 0cb8710 Compare January 29, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants