Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /download/qualcomm-iot refresh #14666

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Jan 21, 2025

Done

  • updated copy as per doc
  • added tabbing functionality
  • updated class/pattern usage to latest Vanilla

QA

Issue / Card

Fixes #https://warthogs.atlassian.net/browse/WD-18266

@webteam-app
Copy link

@mtruj013 mtruj013 changed the title Apply page refresh feat: /download/qualcomm-iot refresh Jan 21, 2025
@eliman11
Copy link

eliman11 commented Jan 21, 2025

Thanks @mtruj013! Agree with your suggestions on the copydoc, so the demo's missing:

  • Change headings to match tabs: Qualcomm RB3 Gen 2 Vision Kkit (QCS6490) and Qualcomm RB3 Gen 2 Lite Vision Kit (QCS5430)
  • Uncapitalize "Release Notes" in the links
  • Delete extra "T" in front of "This is the Beta release of Ubuntu on Qualcomm IoT Platforms for QCS5430. The certified version is coming soon."

Edit: Just received feedback from the stakeholder for the following additional changes:

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@fd144e6). Learn more about missing BASE report.
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14666   +/-   ##
=======================================
  Coverage        ?   72.32%           
=======================================
  Files           ?      120           
  Lines           ?     3404           
  Branches        ?     1172           
=======================================
  Hits            ?     2462           
  Misses          ?      917           
  Partials        ?       25           

@eliman11
Copy link

Looks great thanks @mtruj013! Adding +1

templates/download/qualcomm-iot/index.html Outdated Show resolved Hide resolved
templates/download/qualcomm-iot/index.html Outdated Show resolved Hide resolved
templates/download/qualcomm-iot/index.html Outdated Show resolved Hide resolved
templates/download/qualcomm-iot/tabs/rb3-gen2-tab.html Outdated Show resolved Hide resolved
templates/download/qualcomm-iot/index.html Outdated Show resolved Hide resolved
@mtruj013 mtruj013 merged commit c1d6694 into canonical:main Jan 23, 2025
16 checks passed
@mtruj013 mtruj013 deleted the qualcomm-refresh branch January 23, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants