-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WD-12879] Rebrand kubernetes/install page #14659
[WD-12879] Rebrand kubernetes/install page #14659
Conversation
425a4a5
to
53d6b01
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## k8s-bubble-refresh #14659 +/- ##
======================================================
- Coverage 74.46% 72.58% -1.89%
======================================================
Files 107 120 +13
Lines 2847 3392 +545
Branches 948 1169 +221
======================================================
+ Hits 2120 2462 +342
- Misses 703 906 +203
Partials 24 24 |
53d6b01
to
63a6c01
Compare
Thanks @muhammad-ali-pk!
|
Thank you @muhammad-ali-pk ! Comments:
For "Multi-node Kubernetes with Cluster API":
All else is could so I'll add a +1 for design :) |
Thanks @eliman11 @mattea-turic. Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
d153bc6
into
canonical:k8s-bubble-refresh
* Rebranded kubernetes/install * Addressed UX comments * Addressed design comments * Added aria labels to links * Used escape codes for angle brackets * Italic texts as per copydoc
Done
QA
Issue / Card
Fixes #WD-12879