Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WD-12879] Rebrand kubernetes/install page #14659

Merged

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Jan 17, 2025

Done

  • Rebranded kubernetes/install

QA

  • Open this demo in your web browser.
    • Make sure to test on mobile, tablet and desktop.
  • Make sure the page matches the Figma design and Copydoc

Issue / Card

Fixes #WD-12879

@webteam-app
Copy link

@muhammad-ali-pk muhammad-ali-pk changed the base branch from main to k8s-bubble-refresh January 17, 2025 13:38
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.58%. Comparing base (cab1ea7) to head (2423a94).
Report is 2169 commits behind head on k8s-bubble-refresh.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           k8s-bubble-refresh   #14659      +/-   ##
======================================================
- Coverage               74.46%   72.58%   -1.89%     
======================================================
  Files                     107      120      +13     
  Lines                    2847     3392     +545     
  Branches                  948     1169     +221     
======================================================
+ Hits                     2120     2462     +342     
- Misses                    703      906     +203     
  Partials                   24       24              

see 35 files with indirect coverage changes

@eliman11
Copy link

eliman11 commented Jan 17, 2025

Thanks @muhammad-ali-pk!

  • Replace '&' with 'and' in "Install Kubernetes with a single command. Canonical Kubernetes comes with in-built networking, gateway, local storage, DNS, load balancer, metrics server & ingress."
  • Could we hide the screenshot at the top with the installation process for smaller screens? It's purely decorative and takes too much space on smaller screens.

@mattea-turic
Copy link
Collaborator

mattea-turic commented Jan 17, 2025

Thank you @muhammad-ali-pk !

Comments:
For hero section:

  • I realise the original format of the image doesn't work at a 3:2 aspect ratio so I've uploaded a new image here if you could use that instead pls!

For "Multi-node Kubernetes with Cluster API":

  • Could you add a <br> after "Kubernetes" in the H2 pls?

All else is could so I'll add a +1 for design :)

@muhammad-ali-pk
Copy link
Contributor Author

Thanks @eliman11 @mattea-turic. Done!

@britneywwc britneywwc self-assigned this Jan 21, 2025
templates/kubernetes/install.html Outdated Show resolved Hide resolved
templates/kubernetes/install.html Outdated Show resolved Hide resolved
templates/kubernetes/install.html Outdated Show resolved Hide resolved
templates/kubernetes/install.html Outdated Show resolved Hide resolved
Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@muhammad-ali-pk muhammad-ali-pk merged commit d153bc6 into canonical:k8s-bubble-refresh Jan 22, 2025
14 of 15 checks passed
@muhammad-ali-pk muhammad-ali-pk deleted the WD-12879 branch January 22, 2025 09:05
mtruj013 pushed a commit that referenced this pull request Feb 4, 2025
* Rebranded kubernetes/install

* Addressed UX comments

* Addressed design comments

* Added aria labels to links

* Used escape codes for angle brackets

* Italic texts as per copydoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants