Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(/kubernetes/managed): Rebrand style and update to american english #14652

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Jan 15, 2025

Done

  • Rebrand based on figma design
  • Updated spelling to american english
  • Some minor copy changes

QA

  • Check out the demo
  • Check it matches the design
  • Check the content matches the copydoc

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12883

@webteam-app
Copy link

@petesfrench
Copy link
Contributor Author

@mattea-turic Can you give this a design review please

@mattea-turic
Copy link
Collaborator

mattea-turic commented Jan 15, 2025

@petesfrench This looks pretty much perfect as is and I honestly don't have anything to add other than if you could:

  • Add a hr for the "Kubernetes-as-a-service..." section on smaller screens
  • And similarly, a hr for the "Managed IT services..." section – again, on smaller screens

Either way, I'm +1ing for design

Edit: @eliman11 lmk that there's a logo missing from the first "They trust us to run their k8s" section, which I've added here

@eliman11
Copy link

eliman11 commented Jan 15, 2025

Thanks @petesfrench! Just a couple minor changes:

  • Change to US spelling: minimise -> minimize in "99.9% guaranteed uptime. All cluster components are highly available and proactively monitored to minimize unplanned downtime."
  • Could we add a h2 tag to the "They trust us to run their K8s" and "They trust us to run their K8s" headings for the logo cloud sections?

Feel free to add UX+1 once you've changed those! Thanks :)

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few super minor comments. Also assumed that the index and what-is-kubernetes changes come from the updated base branch and won't be included in this pr once this is rebased, but lmk if you need me to look at changes there as well

templates/kubernetes/managed.html Outdated Show resolved Hide resolved
templates/kubernetes/managed.html Outdated Show resolved Hide resolved
templates/kubernetes/managed.html Outdated Show resolved Hide resolved
@petesfrench petesfrench merged commit c5f32c6 into k8s-bubble-refresh Jan 20, 2025
25 checks passed
@petesfrench petesfrench deleted the wd-12883 branch January 20, 2025 19:16
mtruj013 pushed a commit that referenced this pull request Feb 4, 2025
…nglish (#14652)

* refactor(/kubernetes/managed): Rebrand style and update to american english

* refactor: Apply changes from design and ux review

* refactor: Apply punctuation changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants