-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(/kubernetes/managed): Rebrand style and update to american english #14652
Conversation
@mattea-turic Can you give this a design review please |
@petesfrench This looks pretty much perfect as is and I honestly don't have anything to add other than if you could:
Either way, I'm +1ing for design Edit: @eliman11 lmk that there's a logo missing from the first "They trust us to run their k8s" section, which I've added here |
Thanks @petesfrench! Just a couple minor changes:
Feel free to add UX+1 once you've changed those! Thanks :) |
ad5cdc6
to
9d7f7da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few super minor comments. Also assumed that the index and what-is-kubernetes changes come from the updated base branch and won't be included in this pr once this is rebased, but lmk if you need me to look at changes there as well
…nglish (#14652) * refactor(/kubernetes/managed): Rebrand style and update to american english * refactor: Apply changes from design and ux review * refactor: Apply punctuation changes
Done
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-12883