-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-16600 Rebrand embedding/landing page #14620
base: feature-rebrand-embedding
Are you sure you want to change the base?
WD-16600 Rebrand embedding/landing page #14620
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-rebrand-embedding #14620 +/- ##
============================================================
Coverage ? 69.64%
============================================================
Files ? 120
Lines ? 3419
Branches ? 1174
============================================================
Hits ? 2381
Misses ? 1013
Partials ? 25 |
Thanks @muhammad-ali-pk ! Looks great, no comments from me on the visual side. I just had a question about loading times, in that the images seem to take a little longer to load than usual. Should I maybe reupload at a smaller file size – or are all the assets optimised well enough by the assets manager, and it's maybe just my wifi today :p Edit: Forgot to check smaller screens:
|
Looks perfect, thank you @muhammad-ali-pk! No comments :) |
Thanks @mattea-turic!
|
As a fly-by, can you add the |
After submitting the form I can't see it being received in marketo. This is likely caused by two of the form field being append to the payload: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a small change on the form to make it work
Done
QA
Issue / Card
Fixes #WD-16600