Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check notice id string before calling api #13650

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Mar 6, 2024

Done

  • Added a validity check for the notice_id

Rationale

  • We keep getting strange requests that should throw 404s but are instead throwing 503s I believe because of the special characters. If we validate the provided notice_id before we make a call to the api it 404s correctly.

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-9449

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13650.demos.haus

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.43%. Comparing base (8ac389f) to head (422b778).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13650      +/-   ##
==========================================
- Coverage   74.46%   74.43%   -0.03%     
==========================================
  Files         107      107              
  Lines        2847     2848       +1     
  Branches      948      948              
==========================================
  Hits         2120     2120              
- Misses        703      704       +1     
  Partials       24       24              

see 1 file with indirect coverage changes

@mtruj013 mtruj013 merged commit 5868739 into canonical:main Mar 6, 2024
14 of 15 checks passed
@mtruj013 mtruj013 deleted the notice-id-bug branch March 6, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants