-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-8067 - page update for iot #13518
Conversation
Demo starting at https://ubuntu-com-13518.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13518 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 107 107
Lines 2838 2838
Branches 946 946
=======================================
Hits 2112 2112
Misses 702 702
Partials 24 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a question for @Sophie-32 on the doc regarding the images. Not sure if the pdm actually did want these to be clickable or if she added the links in the wrong place accidentally
Might be my mistake, but I don't see 'Learn more about Ubuntu Core' on the copydoc, do you know where you added that from? |
@Sophie-32 I didn't, it was already there. Removed it now, please check again |
Small suggestion: given that the "Discover Ubuntu IoT in your industry" section operates as a navigation, let's add a chevron to every heading so it's clear it's not just a heading, but also a link. Please, also make them H3 instead of H2s (keep the styling), they are under an H2 already. |
Done
Update /internet-of-things page according to copy doc
QA
./run serve
Issue / Card
WD-8067
Fixes #
Screenshots