Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-8067 - page update for iot #13518

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Conversation

lizzochek
Copy link
Contributor

@lizzochek lizzochek commented Jan 31, 2024

Done

Update /internet-of-things page according to copy doc

QA

  • demo link
  • copy doc
  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8001/
  • Run through the following QA steps
  • Check that the links and text are correct

Issue / Card

WD-8067

Fixes #

Screenshots

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13518.demos.haus

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e32d2bf) 74.41% compared to head (5032b03) 74.41%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13518   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         107      107           
  Lines        2838     2838           
  Branches      946      946           
=======================================
  Hits         2112     2112           
  Misses        702      702           
  Partials       24       24           

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a question for @Sophie-32 on the doc regarding the images. Not sure if the pdm actually did want these to be clickable or if she added the links in the wrong place accidentally

@Sophie-32
Copy link

Might be my mistake, but I don't see 'Learn more about Ubuntu Core' on the copydoc, do you know where you added that from?

@lizzochek lizzochek changed the title WD-8007 - page update for iot WD-8067 - page update for iot Jan 31, 2024
@lizzochek
Copy link
Contributor Author

@Sophie-32 I didn't, it was already there. Removed it now, please check again

@juanruitina
Copy link
Contributor

Small suggestion: given that the "Discover Ubuntu IoT in your industry" section operates as a navigation, let's add a chevron to every heading so it's clear it's not just a heading, but also a link. Please, also make them H3 instead of H2s (keep the styling), they are under an H2 already.

@lizzochek lizzochek merged commit b6f47c3 into canonical:main Feb 1, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants