Skip to content

Commit

Permalink
refactor: Apply changes from code&qa
Browse files Browse the repository at this point in the history
  • Loading branch information
petesfrench committed Jan 22, 2025
1 parent 77a74e0 commit 6999375
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 7 deletions.
23 changes: 21 additions & 2 deletions templates/kubernetes/resources.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<div class="row--50-50">
<div class="col">
<h1>
Understand Kubernetes:
Learn Kubernetes:
<br />
Resources
</h1>
Expand Down Expand Up @@ -125,6 +125,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -161,6 +162,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -195,6 +197,7 @@ <h1>
width="1800",
height="1014",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -230,6 +233,7 @@ <h1>
width="1800",
height="1014",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -267,6 +271,7 @@ <h1>
width="1800",
height="1014",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -316,7 +321,7 @@ <h1>
) -%}

{%- if slot == "title_link" -%}
<a href="/engage/European-space-agency-case-study"
<a href="/case-study/esa"
aria-label="Read the 'Canonical deploys infrastructure solutions and managed IT services for critical space mission operations' case study">Canonical deploys infrastructure solutions and managed IT services for critical space mission operations</a>
{%- endif -%}

Expand All @@ -332,6 +337,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand All @@ -357,6 +363,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -385,6 +392,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -413,6 +421,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -449,6 +458,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand All @@ -475,6 +485,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -514,6 +525,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -546,6 +558,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -580,6 +593,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -614,6 +628,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -646,6 +661,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down Expand Up @@ -741,6 +757,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand All @@ -766,6 +783,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand All @@ -791,6 +809,7 @@ <h1>
width="852",
height="480",
hi_def=False,
attrs={"class": "p-image-container__image"},
loading="auto") | safe
}}
{%- endif -%}
Expand Down
10 changes: 5 additions & 5 deletions templates/macros/_macros-resource.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="col-3 col-medium-3">
{%- set author_links = caller("author_links") -%}
{%- if author_links|trim|length > 0 -%}
<p class="u-no-margin--bottom u-hide--medium u-hide--small">
<p class="p-heading--5 u-no-margin--bottom u-hide--medium u-hide--small">
{{ author_links | safe }}
</p>
{%- endif -%}
Expand All @@ -23,15 +23,15 @@

{%- set title_link = caller("title_link") -%}
{%- if title_link|trim|length > 0 -%}
<h2 class="p-heading--4 u-hide--large u-hide--small" style="padding-top: 0.375rem;">
<h2 class="p-heading--4 u-hide--large u-hide--small u-no-padding--top">
{{ title_link | safe }}
</h2>
{%- endif -%}
</div>

<div class="col-6 col-medium-3">
{%- if title_link|trim|length > 0 -%}
<h2 class="p-heading--4 u-hide--medium">
<h2 class="p-heading--4 u-hide--medium" style="padding-top: 0.275rem;">
{{ title_link | safe }}
</h2>
{%- endif -%}
Expand All @@ -43,7 +43,7 @@

{%- if author_links|trim|length > 0 -%}
<hr class="p-rule--muted u-hide--large u-hide--small" />
<p class="u-no-margin--bottom u-hide--large">
<p class="p-heading--5 u-no-margin--bottom u-hide--large">
{{ author_links | safe }}
</p>
{%- endif -%}
Expand All @@ -56,7 +56,7 @@
<div class="col-3 u-hide--medium u-hide--small">
{%- set image = caller("image") -%}
{%- if image|trim|length > 0 -%}
<div>{{ image | safe }}</div>
<div class="p-image-container--16-9 is-cover">{{ image | safe }}</div>
{%- endif -%}
</div>
</div>
Expand Down

0 comments on commit 6999375

Please sign in to comment.