feat: don't allow modification of unsupported disks #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-loose
added
the
snap/ubuntu-desktop-bootstrap
sminez
reviewed
Feb 11, 2025
sminez
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI changes to support canonical/subiquity#2157
Screencast using probe data and curtin as mentioned in the PR above:
Screencast.From.2025-02-11.11-34-16.webm
In this case
/dev/sdais marked asunsupported, so the UI blocks adding/removing/modifying the disk's partitions and setting it as the boot device. Reformatting the entire disk works as usual, though.@ogayot FYI
UDENG-5999