feat: prevent formatting /boot as VFAT in partition editor
#886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also: simplify redundant mountpoint validation
d-loose
force-pushed
the
prevent-vfat-boot
branch
from
4336f87 to
e9b64e4
Compare
sminez
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the most common errors related to manual partitioning seems to be users trying to use
VFATfor/boot, see e.g. lp:2064678.To prevent the user from doing so, this PR disables the "Ok" button in the partition creation and modification dialogs and shows an error message. Eventually, it'd be desirable to have an additional check with an appropriate error response in subiquity.
I've briefly explored some richer error messaging with @anasereijo, but ultimately decided to keep it short, based on @seb128's recommendation.
@sminez I mentioned that I'd try to refactor this somewhat old-timey Flutter code, but postponed it for now since it's (once again) more work than expected.
UDENG-5519