docs: adding how to add language packs in autoinstall.yaml #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-hagemann
force-pushed
the
gis-language-docs
branch
from
b0d9d29 to
dd360c2
Compare
spydon
reviewed
Sep 9, 2024
seb128
requested changes
Sep 9, 2024
spydon
reviewed
Sep 10, 2024
Adding better comments to why packages are excluded conditionally Remove unneeded exclusions
|
Thanks for the review @seb128 🙂 I've simplified the conditions a little and documented them better. Skipping libreoffice language packs is not conditional based on if |
matthew-hagemann
force-pushed
the
gis-language-docs
branch
from
19a598d to
92461dc
Compare
matthew-hagemann
force-pushed
the
gis-language-docs
branch
from
92461dc to
e43088a
Compare
seb128
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Thanks. I've requested one change inline, but I also don't understand the libreoffice handling there
If you check /usr/share/language-selector/data/pkg_depends the libreoffice packages will be returned by check-language-support --show-installed -l "$lang" if libreoffice-common is installed so we shouldn't need any special handling?
libreoffice packages only show up in --show-installed if libreoffice-common is installed, so no special handling is needed.
seb128
approved these changes
Sep 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Adding a section on how to install additional language packs to appear in GIS via running late-commands in the `autoinstall.yaml` This is doubled up as its applicable to two flow's
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Adding a section on how to install additional language packs to appear in GIS via running late-commands in the `autoinstall.yaml` This is doubled up as its applicable to two flow's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a section on how to install additional language packs to appear in GIS via running late-commands in the
autoinstall.yamlThis is doubled up as its applicable to two flow's