generator: update to match Subiquity moved API types #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subiquity is moving API types away from subiquity/common/types.py into
subiquity/common/types/{__init__,storage}.py. Ensure the makefile
follows the new architecture.
Signed-off-by: Olivier Gayot <[email protected]>
d-loose
added a commit
that referenced
this pull request
Sep 6, 2024
This sets up the main development branch in this repo to track subiquity's `main` branch. I've included @ogayot's change #769 for the type generator and used it to update the Dart classes. I also removed some remaining parts of the decommissioned WSL setup (see internal spec WS030), since the the corresponding types have been removed from subiquity. For additional 24.04.x bug fixes we will use the new `ubuntu/24.04`, which still tracks subiquity's `ubuntu/noble` branch. I'm also removing the remaining snapcraft files for ubuntu-desktop-bootstrap here. We're migrating to the new setup (internal specs UD064 and UD068) with the snapcraft files now located on dedicated branches (`snap/ubuntu-destkop-bootstrap/main` in this case). I'll follow up with a proper documentation update next week.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
This sets up the main development branch in this repo to track subiquity's `main` branch. I've included @ogayot's change #769 for the type generator and used it to update the Dart classes. I also removed some remaining parts of the decommissioned WSL setup (see internal spec WS030), since the the corresponding types have been removed from subiquity. For additional 24.04.x bug fixes we will use the new `ubuntu/24.04`, which still tracks subiquity's `ubuntu/noble` branch. I'm also removing the remaining snapcraft files for ubuntu-desktop-bootstrap here. We're migrating to the new setup (internal specs UD064 and UD068) with the snapcraft files now located on dedicated branches (`snap/ubuntu-destkop-bootstrap/main` in this case). I'll follow up with a proper documentation update next week.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
This sets up the main development branch in this repo to track subiquity's `main` branch. I've included @ogayot's change #769 for the type generator and used it to update the Dart classes. I also removed some remaining parts of the decommissioned WSL setup (see internal spec WS030), since the the corresponding types have been removed from subiquity. For additional 24.04.x bug fixes we will use the new `ubuntu/24.04`, which still tracks subiquity's `ubuntu/noble` branch. I'm also removing the remaining snapcraft files for ubuntu-desktop-bootstrap here. We're migrating to the new setup (internal specs UD064 and UD068) with the snapcraft files now located on dedicated branches (`snap/ubuntu-destkop-bootstrap/main` in this case). I'll follow up with a proper documentation update next week.
|
Superseded by #811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subiquity is moving API types away from subiquity/common/types.py into subiquity/common/types/{init,storage}.py. Ensure the makefile follows the new architecture.
Marking as a draft for now. This will be needed once canonical/subiquity#2010 lands in udi.