Move storage types to a different module #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have many types defined in commont/types.py and it is getting difficult to navigate. By moving their definition to a module, we will be able to move some of those to a different file. Signed-off-by: Olivier Gayot <[email protected]>
The documentation (i.e., a comment) of the common/types module was written before the split between client/server processes split. Refresh it with up-to-date info and also make it a doctstring to be more useful. Signed-off-by: Olivier Gayot <[email protected]>
Signed-off-by: Olivier Gayot <[email protected]>
Chris-Peterson444
approved these changes
Jun 11, 2024
mwhudson
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types.py module is getting difficult to navigate and I would like to split it into multiple units. This PR moves all the storage related types to a different module.
I have already opened a PR in udi to support multiple files in the generator: canonical/ubuntu-desktop-provision#765
which should allow to apply the following in https://github.com/canonical/ubuntu-desktop-provision/blob/main/packages/subiquity_client/Makefile: