Skip to content

Commit

Permalink
multiple changes from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
matthew-hagemann committed Nov 17, 2023
1 parent d7e7140 commit b1607b2
Showing 1 changed file with 5 additions and 20 deletions.
25 changes: 5 additions & 20 deletions .github/workflows/ci.yml → .github/workflows/qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,8 @@ on:
pull_request:
workflow_dispatch:

env:
APT_DEPS: >-
libglib2.0-dev
gcc
gettext
libpam0g-dev
jobs:
analyze:
flutter-analyze:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -57,7 +50,7 @@ jobs:
env:
SUBIQUITY_REPLAY_TIMESCALE: 100

coverage:
flutter-coverage:
runs-on: ubuntu-22.04
strategy:
matrix:
Expand All @@ -83,7 +76,7 @@ jobs:
with:
token: ${{secrets.CODECOV_TOKEN}}

format:
flutter-format:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -112,7 +105,7 @@ jobs:
- run: xvfb-run -a -s '-screen 0 1024x768x24 +extension GLX' flutter test integration_test/${{matrix.target}}
working-directory: packages/ubuntu_init

mocks:
flutter-mocks:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -156,7 +149,7 @@ jobs:
branch: create-pull-request/l10n
delete-branch: true

test:
flutter-tests:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
Expand All @@ -182,10 +175,6 @@ jobs:
name: "Go: Code sanity"
runs-on: ubuntu-latest
steps:
- name: Install dependencies
run: |
sudo DEBIAN_FRONTEND=noninteractive apt update
sudo DEBIAN_FRONTEND=noninteractive apt install -y ${{ env.apt_deps }}
- uses: actions/checkout@v4
- name: Go code sanity check
uses: canonical/desktop-engineering/gh-actions/go/code-sanity@main
Expand All @@ -211,10 +200,6 @@ jobs:
with:
go-version-file: "./provd/go.mod"

- name: Install dependencies
run: |
sudo DEBIAN_FRONTEND=noninteractive apt update
sudo DEBIAN_FRONTEND=noninteractive apt install -y ${{ env.apt_deps }}
- name: Run tests
run: |
set -eu
Expand Down

0 comments on commit b1607b2

Please sign in to comment.