scripts: mirror-checker check all mirrors #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Peterson444
force-pushed
the
mirror-checker-script
branch
from
fed7118 to
e5a2caf
Compare
dbungert
approved these changes
Nov 21, 2024
Theoretically a domain could have multiple CNAME records, even if it's out of spec. Let's not try to debootstrap from these mirrors and report them bad at the point of configuration. Co-authored-by: Dan Bungert <[email protected]>
Print mirrors with "not ok" status at the bottom so they're easier to find when reading the logs. Co-authored-by: Dan Bungert <[email protected]>
|
Thanks for the feedback. I think both suggestions were great and went ahead and implemented them. I'm trying something new and added you as co-author for the commits that include your suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update to the mirror checker script to add a command for checking all of the country mirrors. The
check-allcommand takes all known country codes and then calculates the actual mirrors to test based on DNS records. The script will print out the DNS information for each attempted mirror (i.e.,cc.archive.ubuntu.com), the calculated real mirrors, and a table with the status of each mirror. It will also save the results of each mirror check in the single mirror check mode style (which is now available under thecheckcommand), which can be specified with the-oflag.By default it will omit reporting information about mirrors which don't exist (i.e., fallback to
archive.ubuntu.com) but can be instructed to provide it with the--allflag.Some examples of the output: https://people.canonical.com/~cpete/mirror-checker-example-output/
We could clean this up a little more at some point, filtering for real mirrors using DNS information got a little messy. I also expect some more iteration on this if we want to set it up for regular monitoring somewhere.