o/snapstate: respect validation sets when refreshing and installing components with snaps #14783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nSets, rather than just a slice of validation set keys
This is a bit of a weird case, since this is in a compatibility branch that I do not think would ever have any relevant validation sets. To be consistent with our current tests, we should still continue providing the enforced validation sets in this case.
…onents with snaps
github-actions
bot
added
the
Needs Documentation -auto-
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14783 +/- ##
==========================================
+ Coverage 78.95% 79.01% +0.06%
==========================================
Files 1084 1087 +3
Lines 146638 148025 +1387
==========================================
+ Hits 115773 116965 +1192
- Misses 23667 23807 +140
- Partials 7198 7253 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that we respect validation sets when installing/refreshing components alongside snaps.
Note that the store doesn't yet fully support introspecting the validation sets that are sent during a refresh, so they cannot yet change which component revisions are actually returned with the actions. We double check the actions that are returned from the store to ensure that we always follow the correct constraints.
Based on #14769 for now.