Sgmoore/add core24 support

[ScarlettGatelyMoore]

• [ x] Have you followed the guidelines for contributing?
• [x ] Have you signed the CLA?
• [x ] Have you successfully run tox run -m lint?
• [x ] Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

---

[codecov]

Codecov Report

Attention: Patch coverage is 95.12195% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.72%. Comparing base (654871d) to head (0d6c38a).
Report is 670 commits behind head on main.

Files with missing lines	Patch %	Lines
snapcraft/extensions/kde_neon.py	96.36%	2 Missing ⚠️
snapcraft/extensions/kde_neon_6.py	92.59%	2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (0d6c38a). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (654871d)	HEAD (0d6c38a)
	2	1

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5092      +/-   ##
==========================================
- Coverage   94.88%   89.72%   -5.16%     
==========================================
  Files         658      341     -317     
  Lines       55189    22649   -32540     
==========================================
- Hits        52364    20321   -32043     
+ Misses       2825     2328     -497     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ScarlettGatelyMoore]

@mr-cal @sergiusens Please help with this security scan. I don't know how to fix it. Thanks

[mr-cal]

@mr-cal @sergiusens Please help with this security scan. I don't know how to fix it. Thanks

Hi @ScarlettGatelyMoore, you can ignore the security scan failures for now, it is a problem between github and trivy that @lengau has been investigating.

This is the error I'm referring to:

2024-10-07T13:30:16Z	FATAL	Fatal error	init error: DB error: failed to download vulnerability DB: database download error: OCI repository error: 1 error occurred:
	* GET https://ghcr.io/v2/aquasecurity/trivy-db/manifests/2: TOOMANYREQUESTS: retry-after: 426.143µs, allowed: 44000/minute

[lengau]

@mr-cal @sergiusens I believe the security scan is fixed with this, but I haven't properly tested it yet so I don't have a PR. ITMT we can just re-run them.

[lengau]

This LGTM so far, but I'd like to snap an app with it before I give explicit approval just in case I come across any quirks we might want to document.

[ScarlettGatelyMoore]

There's nothing useful in the log. I'll run it again and see if it fails again.

It looks like last rebase fixed it.

[mr-cal]

@ScarlettGatelyMoore - is this ready for review?

[ScarlettGatelyMoore]

Yes... please.

[ScarlettGatelyMoore]

@ScarlettGatelyMoore - is this ready for review?
Hi! Sorry, just released from hospital. Just rebased and hopefully we can get this approved soon? Thanks!

[mr-cal]

I will review this week

[mr-cal]

Looks good, just some minor feedback.

[lengau]

LGTM! I installed this branch and built a Keysmith snap off it, which I intend to make a merge request for as soon as this lands on stable.

[ScarlettGatelyMoore]

Done! Thanks!

[ScarlettGatelyMoore]

Well it's broken now after @lengau error change. I am confused as to why. I can't find where the call is coming from and our snaps have worked just fine. I have added the file it is demanding to the content snap, but it will be awhile before it will be done. This makes zero sense to me.

[ScarlettGatelyMoore]

please re-trigger tests @mr-cal @lengau

[mr-cal]

Thank you for all your work on this! I will get it merged.

[luzpaz]

Apologies, just wondering if there's an ETA on when this will be released?

[mr-cal]

Apologies, just wondering if there's an ETA on when this will be released?

It will be in Snapcraft 8.6, which should be on the candidate channel by 2024-Jan-20.