Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: push tags for remote-build #4460

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: push tags for remote-build #4460

merged 1 commit into from
Dec 1, 2023

Conversation

sergiusens
Copy link
Collaborator

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

mr-cal
mr-cal reviewed Nov 30, 2023
View reviewed changes
snapcraft/remote/git.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3069141) 89.18% compared to head (36f2cb5) 89.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4460   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files         321      321           
  Lines       21665    21668    +3     
=======================================
+ Hits        19322    19325    +3     
  Misses       2343     2343

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiusens sergiusens marked this pull request as ready for review November 30, 2023 23:33
@sergiusens sergiusens requested review from mr-cal and lengau November 30, 2023 23:33
@sergiusens
Copy link
Collaborator Author

fyi @cjdcordeiro

mr-cal
mr-cal approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

snapcraft/remote/git.py Show resolved Hide resolved
snapcraft/remote/git.py Show resolved Hide resolved
snapcraft/remote/git.py Outdated Show resolved Hide resolved
lengau
lengau reviewed Dec 1, 2023
View reviewed changes
snapcraft/remote/git.py Outdated Show resolved Hide resolved
lengau
lengau approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiusens
fix: push tags for remote-build
36f2cb5 
Signed-off-by: Sergio Schvezov <[email protected]>
@sergiusens sergiusens merged commit 21f6ad7 into main Dec 1, 2023
8 checks passed
@sergiusens sergiusens deleted the push-tags branch December 1, 2023 10:37
@Porkepix Porkepix mentioned this pull request Dec 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergiusens @codecov-commenter @lengau @mr-cal