Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump craft-store to 2.5.0 #4455

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Nov 23, 2023

Allows headless systems to fallback to a file based keyring backend.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

To verify, the following would fail

multipass shell
snap install snapcraft
snapcraft login

but,

snap refresh snapcraft edge/pr-4455
snapcraft login
snapcraft whoami

would work

Allows headless systems to fallback to a file based keyring backend.

Signed-off-by: Sergio Schvezov <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ddaf75) 94.88% compared to head (7356def) 94.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           hotfix/7.5    #4455   +/-   ##
===========================================
  Coverage       94.88%   94.88%           
===========================================
  Files             658      658           
  Lines           55192    55192           
===========================================
+ Hits            52367    52369    +2     
+ Misses           2825     2823    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiusens sergiusens merged commit 9b5c2f4 into hotfix/7.5 Nov 23, 2023
11 of 12 checks passed
@sergiusens sergiusens deleted the craft-store-2.5.0 branch November 23, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants