-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] ci: improve linter output in github actions #4422
Conversation
Signed-off-by: Callahan Kovacs <[email protected]>
9756412
to
bd3e408
Compare
Signed-off-by: Callahan Kovacs <[email protected]>
bd3e408
to
e1cf828
Compare
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
33e7ad5
to
4faf267
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #4422 +/- ##
==========================================
- Coverage 89.18% 89.16% -0.02%
==========================================
Files 322 321 -1
Lines 21659 21610 -49
==========================================
- Hits 19316 19269 -47
+ Misses 2343 2341 -2 see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
commands_pre = | ||
bash -c "[ -n \"$CI\" ] && echo \"::group::$TOX_ENV_NAME\" || exit 0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have liked to add commands_pre
and commands_post
once to the [lint]
section on line 79, but they don't execute if commands_pre
or commands_post
are defined in the "child" sections (like this one).
@@ -46,7 +46,7 @@ jobs: | |||
snap watch --last=install | |||
echo "::endgroup::" | |||
- name: Run Linters | |||
run: tox run --skip-pkg-install -m lint | |||
run: tox run --no-list-dependencies --skip-pkg-install --colored=yes -m lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--no-list-dependencies
isn't automatically being used by default in github actions
I need to do some more research. For some reason, craft-providers is automatically making collapsible sections while snapcraft is not: https://github.com/canonical/craft-providers/actions/runs/6645888307/job/18058153606?pr=436 |
Closing in favor of #4435 |
make lint
?pytest tests/unit
?Improve output of linters in CI with:
See the output here:
https://github.com/snapcore/snapcraft/actions/runs/6645154367/job/18055825986?pr=4422#step:5:1