Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update craft-providers to 1.18.0 #4409

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 18, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Update craft-providers to 1.18.0. The primary motivation for this PR is to capture stdout and stderr when installing a snap inside an instance fails. There are some other performance improvements when creating base instances for LXD.

1.17.0 introduces the global pip cache, but this is an opt-in feature so snapcraft's behavior is unchanged.

Changelog

1.18.0 (2023-09-28)

  • Check if base instance status before copying
  • Fail quickly when LXD errors do not involve instance creation
  • Add check parameter to execute_run

1.17.0 (2023-09-22)

  • Use a shared pip cache across instances
  • Remove Ubuntu 22.10 (Kinetic) support
  • Capture details for snap errors

1.16.0 (2023-08-25)

  • Improve LXD instance creation process to avoid race conditions. The base instance is now created first and copied to an instance. Retry, timeout, and locking mechanisms prevent multiple processes from creating the same base instance.
  • Add LXD functions check_instance_status(), config_set(), config_get(), and restart()

@mr-cal mr-cal requested a review from a team October 18, 2023 20:53
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #4409 (d6b801c) into main (feb701d) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #4409      +/-   ##
==========================================
+ Coverage   89.17%   89.18%   +0.01%     
==========================================
  Files         321      322       +1     
  Lines       21608    21657      +49     
==========================================
+ Hits        19268    19315      +47     
- Misses       2340     2342       +2     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal merged commit bf37fd4 into main Oct 19, 2023
@mr-cal mr-cal deleted the craft-providers-1.18.0 branch October 19, 2023 13:41
Hook25 pushed a commit to Hook25/snapcraft that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants