Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDE: new content pack update. #4403

Merged
merged 28 commits into from
Feb 21, 2024

Conversation

ScarlettGatelyMoore
Copy link
Contributor

@ScarlettGatelyMoore ScarlettGatelyMoore commented Oct 17, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bf03c2) 88.33% compared to head (f46edfd) 88.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4403      +/-   ##
==========================================
+ Coverage   88.33%   88.35%   +0.01%     
==========================================
  Files         327      328       +1     
  Lines       21966    22015      +49     
==========================================
+ Hits        19404    19451      +47     
- Misses       2562     2564       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiusens
Copy link
Collaborator

there seems to still be a test failing here related to this change

@ScarlettGatelyMoore
Copy link
Contributor Author

there seems to still be a test failing here related to this change

Sorry. I can be real dumb sometimes. All should be green here shortly.

@lengau lengau self-requested a review January 30, 2024 22:09
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this!

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac421ab) 88.33% compared to head (08ba312) 88.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4403      +/-   ##
==========================================
+ Coverage   88.33%   88.35%   +0.01%     
==========================================
  Files         327      328       +1     
  Lines       21966    22015      +49     
==========================================
+ Hits        19404    19451      +47     
- Misses       2562     2564       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lengau lengau requested a review from sergiusens February 21, 2024 18:25
@lengau
Copy link
Contributor

lengau commented Feb 21, 2024

@sergiusens we'll probably need an override here. The CLA check failure is due to the github-assigned email, but @soumyaDghosh has signed the CLA (see: https://launchpad.net/~soumyadghosh)

@ScarlettGatelyMoore
Copy link
Contributor Author

@sergiusens we'll probably need an override here. The CLA check failure is due to the github-assigned email, but @soumyaDghosh has signed the CLA (see: https://launchpad.net/~soumyadghosh)

And so have I... https://launchpad.net/~scarlettmoore

@sergiusens sergiusens merged commit 0870df3 into canonical:main Feb 21, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants