-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDE: new content pack update. #4403
KDE: new content pack update. #4403
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4403 +/- ##
==========================================
+ Coverage 88.33% 88.35% +0.01%
==========================================
Files 327 328 +1
Lines 21966 22015 +49
==========================================
+ Hits 19404 19451 +47
- Misses 2562 2564 +2 ☔ View full report in Codecov by Sentry. |
there seems to still be a test failing here related to this change |
Sorry. I can be real dumb sometimes. All should be green here shortly. |
… path (canonical#4451) Signed-off-by: Callahan Kovacs <[email protected]> Co-authored-by: Alex Lowe <[email protected]> Co-authored-by: Callahan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4403 +/- ##
==========================================
+ Coverage 88.33% 88.35% +0.01%
==========================================
Files 327 328 +1
Lines 21966 22015 +49
==========================================
+ Hits 19404 19451 +47
- Misses 2562 2564 +2 ☔ View full report in Codecov by Sentry. |
@sergiusens we'll probably need an override here. The CLA check failure is due to the github-assigned email, but @soumyaDghosh has signed the CLA (see: https://launchpad.net/~soumyadghosh) |
And so have I... https://launchpad.net/~scarlettmoore |
make lint
?pytest tests/unit
?