Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename remote-build test #4383

Merged
merged 1 commit into from
Sep 26, 2023
Merged

chore: rename remote-build test #4383

merged 1 commit into from
Sep 26, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 26, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Pedantic change: the name of the module and test should match.

snapcraft/commands/remote.py => tests/unit/commands/test_remote.py

@mr-cal
chore: rename remote-build test
427ae32 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal mr-cal requested review from cmatsuoka and syu-w September 26, 2023 16:53
@mr-cal mr-cal merged commit 4f7f4a5 into main Sep 26, 2023
@mr-cal mr-cal deleted the remote-rename-test branch September 26, 2023 19:30
@Porkepix Porkepix mentioned this pull request Dec 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syu-w syu-w syu-w approved these changes

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @cmatsuoka @syu-w