Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add pygit to doc requirements #4375

Merged
merged 1 commit into from
Sep 22, 2023
Merged

chore(deps): add pygit to doc requirements #4375

merged 1 commit into from
Sep 22, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 21, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

#4368 broke sphinx:

 python -m sphinx -T -E -W --keep-going -b html -d _build/doctrees -D language=en . $READTHEDOCS_OUTPUT/html
Running Sphinx v7.2.6
making output directory... done
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/gen_cli_docs.py", line 13, in <module>
    from snapcraft import cli
  File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/cli.py", line 37, in <module>
    from . import commands
  File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/commands/__init__.py", line 63, in <module>
    from .remote import RemoteBuildCommand
  File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/commands/remote.py", line 33, in <module>
    from snapcraft.remote import is_repo
  File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/remote/__init__.py", line 20, in <module>
    from .git import GitRepo, is_repo
  File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/remote/git.py", line 22, in <module>
    import pygit2
ModuleNotFoundError: No module named 'pygit2'

@mr-cal mr-cal requested a review from lengau September 21, 2023 22:18
@mr-cal mr-cal merged commit e340be1 into main Sep 22, 2023
@mr-cal mr-cal deleted the doc-requirements branch September 22, 2023 14:04
@lengau lengau mentioned this pull request Sep 22, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants