Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remote-build): check if project is in a git repository #4370

Merged
merged 1 commit into from
Sep 21, 2023
Merged

feat(remote-build): check if project is in a git repository #4370

merged 1 commit into from
Sep 21, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 21, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

This is the last bit of control logic for remote-build.

If a snapcraft project is not in a git repository, execute the legacy remote-build code.

Fixes #4321
(CRAFT-1976)

@mr-cal mr-cal requested review from tigarmo and lengau September 21, 2023 14:16
@sergiusens sergiusens merged commit e0ef5ec into main Sep 21, 2023
@sergiusens sergiusens deleted the remote-build-git branch September 21, 2023 17:57
@Porkepix Porkepix mentioned this pull request Dec 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@sergiusens sergiusens sergiusens approved these changes

@lengau lengau Awaiting requested review from lengau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remote-build: add control logic when the project is in a git repo
3 participants
@mr-cal @sergiusens @tigarmo