feat(remote-build): check SNAPCRAFT_REMOTE_BUILD_STRATEGY envvar #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valid values for the environment variable are: - `disable-fallback`: uses new remote-build code - `force-fallback`: uses legacy remote-build code This envar is used for bases core22 and older. Bases newer than core22 use the new remote-build code. Signed-off-by: Callahan Kovacs <[email protected]>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #4353 +/- ##
==========================================
+ Coverage 89.19% 89.21% +0.01%
==========================================
Files 300 300
Lines 20648 20672 +24
==========================================
+ Hits 18418 18442 +24
Misses 2230 2230
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
sergiusens
approved these changes
Sep 6, 2023
lengau
reviewed
Sep 7, 2023
Signed-off-by: Callahan Kovacs <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?Valid values for the environment variable are:
disable-fallback: uses new remote-build codeforce-fallback: uses legacy remote-build codeThis envar is used for bases core22 and older. Bases newer than core22 use the new remote-build code.
Fixes #4319
(CRAFT-1974)