fix: reprime for try #4347
Merged
fix: reprime for try #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the case where prime was run before try, where a subsequent run of try would mask the contents of the existing prime directory with a newly mounted one from the host. In legacy we had the concept of `clean --unprime` to solve this. Signed-off-by: Sergio Schvezov <[email protected]>
sergiusens
force-pushed
the
reprime-7.5
branch
from
4e5c3c5 to
526fad1
Compare
|
Fixes #4219 |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## hotfix/7.5 #4347 +/- ##
==============================================
- Coverage 94.88% 94.88% -0.01%
==============================================
Files 658 658
Lines 55122 55132 +10
==============================================
+ Hits 52303 52312 +9
- Misses 2819 2820 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mr-cal
approved these changes
Sep 5, 2023
tigarmo
approved these changes
Sep 5, 2023
Co-authored-by: Tiago Nobrega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the case where prime was run before try, where a subsequent run of try would mask the contents of the existing prime directory with a newly mounted one from the host. In legacy we had the concept of
clean --unprimeto solve this.make lint?pytest tests/unit?Fixes #4219